Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001403002: Remove //mojo/platform_handle (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@wrapper-apis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //mojo/platform_handle The library is obviated by the new public C API for platform handles. See https://codereview.chromium.org/1995753002. This CL removes all remaining references to the now-empty build targets and wipes out the directory. BUG=None TBR=ben@chromium.org Committed: https://crrev.com/7afa85d212bf3ebbccab06292807ef60754aea92 Cr-Commit-Position: refs/heads/master@{#395530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -74 lines) Patch
M components/filesystem/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M components/filesystem/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/filesystem/filesystem.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/font_service/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/leveldb/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M components/leveldb/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M components/mus/gles2/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gpu/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/wm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/mojo_platform_handle.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/platform_handle/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/public/mojo_application.gni View 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M services/shell/shell.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M services/user/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/user/user.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1995753002 Patch 260001

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001403002/1
4 years, 7 months ago (2016-05-24 03:49:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 04:56:21 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 04:57:58 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7afa85d212bf3ebbccab06292807ef60754aea92
Cr-Commit-Position: refs/heads/master@{#395530}

Powered by Google App Engine
This is Rietveld 408576698