Issue 20014005: Fix duplicated methods for POSIX platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20014005: Fix duplicated methods for POSIX platforms. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
Sven Panne, Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix duplicated methods for POSIX platforms. No need to duplicate OS::NumberOfCores() for every POSIX platform. No need to duplicate OS::Sleep() for every POSIX platform. No need to duplicate OS::Abort() and OS::DebugBreak() for every POSIX platform. No need to duplicate OS::Free() for every POSIX platform. Move #ifdef'd OS::ProtectCode() and OS::Guard() to platform-posix.cc. No need to duplicate OS::AllocateAlignment() for every POSIX platform. No need to duplicate OS::PostSetUp() for every POSIX platform. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15820

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -275 lines)			Patch
M	src/platform-cygwin.cc	View	3 chunks	+0 lines, -52 lines	0 comments	Download
M	src/platform-freebsd.cc	View	3 chunks	+0 lines, -44 lines	0 comments	Download
M	src/platform-linux.cc	View	3 chunks	+0 lines, -53 lines	0 comments	Download
M	src/platform-macos.cc	View	3 chunks	+0 lines, -39 lines	0 comments	Download
M	src/platform-openbsd.cc	View	3 chunks	+0 lines, -40 lines	0 comments	Download
M	src/platform-posix.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/platform-posix.cc	View	4 chunks	+62 lines, -4 lines	0 comments	Download
M	src/platform-solaris.cc	View	3 chunks	+0 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

7 years, 5 months ago (2013-07-23 09:59:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15820 (presubmit successful).

Expand Messages | Collapse Messages