Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 20014: Add the first unit-test that tests our IME backend.... (Closed)

Created:
10 years, 6 months ago by Hironori Bono
Modified:
8 years, 3 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add the first unit-test that tests our IME backend. This change is the first unit-test that tests our IME backend in the RenderWidget class. Thanks to the unit-test framework for the RenderView class created by Carlos and Brett, we can now implement this unit test. (I'm not sure I use this framework correctly, though. Please blame me if I use it improperly.) Currently, this IME test just tests if our IME code can properly activate (or de-activate) IMEs for an <input> element and the initial position of a candidate window. I'm going to add more practical cases to this test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9648

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M chrome/renderer/render_view.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/render_view_unittest.cc View 1 2 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hironori Bono
10 years, 6 months ago (2009-02-03 10:05:13 UTC) #1
brettw
This is great, I really appreciate you taking the time to write this test. LGTM.
10 years, 6 months ago (2009-02-03 16:15:18 UTC) #2
jungshik at Google
10 years, 6 months ago (2009-02-03 18:08:34 UTC) #3
lgtm !

Powered by Google App Engine
This is Rietveld 408576698