Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2001393004: TypedArray: Make byteOffset, byteLength, and length properties configurable (Closed)

Created:
4 years, 7 months ago by gsathya
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

TypedArray: Make byteOffset, byteLength, and length configurable Removes the DONT_DELETE enum bit from the properties to make them configurable. Also, updates the regress-typedarray-length test to -- - Check for true boolean return value on deletion of these properties. - Check for undefined return value on trying to access these properties after deletion. BUG=v8:4902 LOG=Y Committed: https://crrev.com/91e2039df065a267096631fc8a81cf9e7c2fec68 Cr-Commit-Position: refs/heads/master@{#36528}

Patch Set 1 #

Patch Set 2 : Remove passing tests from test262.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -35 lines) Patch
M src/js/typedarray.js View 1 chunk +4 lines, -5 lines 0 comments Download
M test/mjsunit/regress/regress-typedarray-length.js View 2 chunks +16 lines, -16 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001393004/1
4 years, 7 months ago (2016-05-24 18:15:44 UTC) #3
gsathya
As per https://bugs.chromium.org/p/v8/issues/detail?id=4902#c3, resending this CL.
4 years, 7 months ago (2016-05-24 18:18:41 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2180) v8_mac_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-24 18:33:07 UTC) #7
adamk
Looks like we now pass some test262 we previously failed, which is why your trybots ...
4 years, 7 months ago (2016-05-24 18:59:15 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001393004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001393004/20001
4 years, 7 months ago (2016-05-24 19:26:48 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 19:53:48 UTC) #12
gsathya
On 2016/05/24 18:59:15, adamk wrote: > Looks like we now pass some test262 we previously ...
4 years, 7 months ago (2016-05-24 19:56:03 UTC) #13
adamk
lgtm
4 years, 7 months ago (2016-05-24 20:01:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001393004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001393004/20001
4 years, 7 months ago (2016-05-25 19:03:54 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 19:07:15 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 19:10:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91e2039df065a267096631fc8a81cf9e7c2fec68
Cr-Commit-Position: refs/heads/master@{#36528}

Powered by Google App Engine
This is Rietveld 408576698