Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2001393003: Revision of "Adjusts dart2js backend to handle method type arguments" (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revision of "Adjusts dart2js backend to handle method type arguments" Adjusted version of CL https://codereview.chromium.org/1976213002/, only changed by adding entries in status files for the test 'tests/language/generic_methods_type_expression_test.dart'. Committed: https://github.com/dart-lang/sdk/commit/af79c19a53959f5770aaab8ecb259bf2fccca80a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -54 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 11 chunks +99 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +33 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +41 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/generic_methods_function_type_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A + tests/language/generic_methods_function_type_test.options View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/generic_methods_new_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A + tests/language/generic_methods_new_test.options View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/generic_methods_type_expression_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
A + tests/language/generic_methods_type_expression_test.options View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/language.status View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
TBR: Same CL as the one landed & reverted yesterday afternoon, except that missing status ...
4 years, 7 months ago (2016-05-24 08:58:32 UTC) #2
eernst
Committed patchset #1 (id:1) manually as af79c19a53959f5770aaab8ecb259bf2fccca80a (presubmit successful).
4 years, 7 months ago (2016-05-24 09:12:14 UTC) #4
Johnni Winther
4 years, 7 months ago (2016-05-24 09:15:25 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698