Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2001383002: MacViewsBrowser: Fix broken compile - renamed method after r395397 (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, karandeepb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViewsBrowser: Fix broken compile - renamed method after r395397 r395397 is "Simplify some old avatar menu button code." `compile` step broke in http://go/macviewsbuilder/builds/10802 with browser_non_client_frame_view_mac.h:42:23: error: only virtual member functions can be marked 'override' void UpdateAvatar() override; It just needs to be renamed to UpdateProfileIcons(). BUG=425229, 614244 TBR=estade@chromium.org Committed: https://crrev.com/25c2cd1a7b9f29b42ce549b98437ad48c92b38f6 Cr-Commit-Position: refs/heads/master@{#395529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tapted
4 years, 7 months ago (2016-05-24 03:21:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001383002/1
4 years, 7 months ago (2016-05-24 03:21:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 03:58:45 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/25c2cd1a7b9f29b42ce549b98437ad48c92b38f6 Cr-Commit-Position: refs/heads/master@{#395529}
4 years, 7 months ago (2016-05-24 04:00:02 UTC) #8
Evan Stade
sorry, lgtm
4 years, 7 months ago (2016-05-24 14:13:55 UTC) #9
tapted
4 years, 7 months ago (2016-05-25 01:19:17 UTC) #10
Message was sent while issue was closed.
On 2016/05/24 14:13:55, Evan Stade wrote:
> sorry, lgtm

no worries! It's our fault for not having a trybot yet :)

Powered by Google App Engine
This is Rietveld 408576698