Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 2001373002: remove row.h from unittests (Closed)

Created:
4 years, 7 months ago by fbarchard1
Modified:
4 years, 6 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

remove row.h from unittests add SIMD_ALIGNED to unittest header. BUG=libyuv:594 TESTED=local build passes with row.h removed from tests. R=harryjin@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/ade85fb55c062d759269b06050feaa1f956c80ca

Patch Set 1 #

Patch Set 2 : use unittest alloc for all unitests #

Patch Set 3 : fix enchmark typo #

Patch Set 4 : fix compare unittest off by 1 #

Patch Set 5 : pad for blur test source #

Patch Set 6 : pad csum #

Patch Set 7 : pad blur destination buffer #

Patch Set 8 : merged with head #

Patch Set 9 : new function for extract alpha use unittest alloc #

Patch Set 10 : disable blur any test #

Patch Set 11 : test csum buffer is aligned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -705 lines) Patch
M source/planar_functions.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -1 line 0 comments Download
M unit_test/color_test.cc View 1 3 chunks +19 lines, -19 lines 0 comments Download
M unit_test/compare_test.cc View 1 2 3 16 chunks +40 lines, -41 lines 0 comments Download
M unit_test/convert_test.cc View 1 2 43 chunks +253 lines, -251 lines 0 comments Download
M unit_test/cpu_test.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M unit_test/math_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M unit_test/planar_test.cc View 1 2 3 4 5 6 7 8 9 38 chunks +154 lines, -355 lines 0 comments Download
M unit_test/rotate_argb_test.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M unit_test/rotate_test.cc View 7 chunks +12 lines, -13 lines 0 comments Download
M unit_test/scale_argb_test.cc View 1 5 chunks +7 lines, -9 lines 0 comments Download
M unit_test/unit_test.h View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fbarchard1
use unittest functions for allocations instead of row.h
4 years, 7 months ago (2016-05-24 18:00:12 UTC) #1
fbarchard1
blur and DetectARGB initially had issues, but try bots pass now.
4 years, 7 months ago (2016-05-26 23:44:09 UTC) #3
harryjin
lgtm
4 years, 7 months ago (2016-05-26 23:59:31 UTC) #4
fbarchard1
4 years, 6 months ago (2016-05-27 17:57:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #11 (id:200001) manually as
ade85fb55c062d759269b06050feaa1f956c80ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698