Issue 200137: Reference perf_id only if set....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200137: Reference perf_id only if set.... (Closed)

Created:
11 years, 3 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/master/

Visibility:
Public.

Description

Reference perf_id only if set. Not all slaves using the log processor set a perf_id. If perf_id is unset, return early from loading performance expectations. BUG=18597 TEST=repro modules linux failure locally, verify this change fixes the crash in setupBuild Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26289

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	log_parser/process_log.py	View		3 chunks	+7 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 3 months ago (2009-09-15 21:47:47 UTC) #2

LGTM

http://codereview.chromium.org/200137/diff/1/2
File log_parser/process_log.py (right):

http://codereview.chromium.org/200137/diff/1/2#newcode155
Line 155: logging.error("not loading perf expectations: perf_id missing")
is this really an error?

Expand Messages | Collapse Messages