Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 200137: Reference perf_id only if set.... (Closed)

Created:
11 years, 3 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/master/
Visibility:
Public.

Description

Reference perf_id only if set. Not all slaves using the log processor set a perf_id. If perf_id is unset, return early from loading performance expectations. BUG=18597 TEST=repro modules linux failure locally, verify this change fixes the crash in setupBuild Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26289

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M log_parser/process_log.py View 3 chunks +7 lines, -4 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
chase
11 years, 3 months ago (2009-09-15 20:16:53 UTC) #1
Nicolas Sylvain
11 years, 3 months ago (2009-09-15 21:47:47 UTC) #2
LGTM

http://codereview.chromium.org/200137/diff/1/2
File log_parser/process_log.py (right):

http://codereview.chromium.org/200137/diff/1/2#newcode155
Line 155: logging.error("not loading perf expectations: perf_id missing")
is this really an error?

Powered by Google App Engine
This is Rietveld 408576698