Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001333002: delete the levelDB storage implementation. (Closed)

Created:
4 years, 7 months ago by bburns
Modified:
4 years, 7 months ago
Reviewers:
fgorski
CC:
chromium-reviews, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, blundell+watchlist_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

delete the levelDB storage implementation. This is a revert of the revert of https://codereview.chromium.org/1999443003/ BUG=599235 Committed: https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41 Cr-Commit-Position: refs/heads/master@{#395477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -692 lines) Patch
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_model_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages.gypi View 3 chunks +0 lines, -17 lines 0 comments Download
M components/offline_pages/BUILD.gn View 3 chunks +0 lines, -7 lines 0 comments Download
M components/offline_pages/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_item.cc View 1 chunk +0 lines, -1 line 0 comments Download
D components/offline_pages/offline_page_metadata_store_impl.h View 1 chunk +0 lines, -90 lines 0 comments Download
D components/offline_pages/offline_page_metadata_store_impl.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M components/offline_pages/offline_page_metadata_store_impl_unittest.cc View 6 chunks +3 lines, -176 lines 0 comments Download
M components/offline_pages/offline_page_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
D components/offline_pages/proto/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D components/offline_pages/proto/offline_pages.proto View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bburns
ptal, this is a revert of the revert.
4 years, 7 months ago (2016-05-23 21:08:11 UTC) #3
fgorski
On 2016/05/23 21:08:11, bburns wrote: > ptal, this is a revert of the revert. lgtm ...
4 years, 7 months ago (2016-05-23 21:16:42 UTC) #4
bburns
On 2016/05/23 21:16:42, fgorski wrote: > On 2016/05/23 21:08:11, bburns wrote: > > ptal, this ...
4 years, 7 months ago (2016-05-23 21:45:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001333002/1
4 years, 7 months ago (2016-05-23 22:58:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 00:19:40 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 00:21:54 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41
Cr-Commit-Position: refs/heads/master@{#395477}

Powered by Google App Engine
This is Rietveld 408576698