Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 200133002: A64: Fixes for the veneers emission. (Closed)

Created:
6 years, 9 months ago by Alexandre Rames
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Fixes for the veneers emission. This patch includes 3 fixes for veneers emission. 1) Block veneer pools emission in the PatchingAssembler. 2) Fix the check for veneer pool emission just before a constant pool. 3) Forbid copy of labels. The list of JumpTableEntry used to track the deoptimization table entries would make copies of the labels when growing. Doing so, it would confuse the Assembler that was tracking the labels via pointers. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M src/a64/assembler-a64.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/a64/assembler-a64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/a64/lithium-codegen-a64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/a64/lithium-codegen-a64.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M src/assembler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexandre Rames
6 years, 9 months ago (2014-03-14 10:16:16 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-14 10:26:36 UTC) #2
Alexandre Rames
6 years, 9 months ago (2014-03-14 15:14:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698