sync/tools/BUILD.gn - Issue 2001323002: Fix some TODO(GYP) in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/tools/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/tools/BUILD.gn

diff --git a/sync/tools/BUILD.gn b/sync/tools/BUILD.gn

index 93c275f04d6fb265413c8c01f5dfc4ff5ea8b8af..a6628f4bea499380fd719b5f77f039d0bb8a13fb 100644

--- a/sync/tools/BUILD.gn

+++ b/sync/tools/BUILD.gn

@@ -4,8 +4,8 @@

import("//testing/test.gni")

-if (is_linux && !is_chromeos) {

- # TODO(GYP): Figure out which of these work and are needed on other platforms.

+# These are used by developers so don't compile on mobile OS's.

+if (!is_ios && !is_android && !is_chromecast) {

brettw 2016/05/23 22:06:26 This matches the condition in src/BUILD.gn.

source_set("common") {

testonly = true