Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: ui/resources/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« ui/gl/BUILD.gn ('K') | « ui/ozone/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 import("//tools/grit/repack.gni") 6 import("//tools/grit/repack.gni")
7 7
8 # GYP version: ui/resources/ui_resources.gyp:ui_resources 8 # GYP version: ui/resources/ui_resources.gyp:ui_resources
9 group("resources") { 9 group("resources") {
10 public_deps = [ 10 public_deps = [
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 deps += [ "//ui/app_list/resources" ] 208 deps += [ "//ui/app_list/resources" ]
209 sources += [ "$root_gen_dir/ui/app_list/resources/app_list_resources_100_per cent.pak" ] 209 sources += [ "$root_gen_dir/ui/app_list/resources/app_list_resources_100_per cent.pak" ]
210 } 210 }
211 } 211 }
212 212
213 # Repack just the strings for the framework locales on Mac and iOS. This 213 # Repack just the strings for the framework locales on Mac and iOS. This
214 # emulates repack_locales.py, but just for en-US. Note ui_test.pak is not simply 214 # emulates repack_locales.py, but just for en-US. Note ui_test.pak is not simply
215 # copied, because it causes leaks from allocations within system libraries when 215 # copied, because it causes leaks from allocations within system libraries when
216 # trying to load non-string resources. http://crbug.com/413034. 216 # trying to load non-string resources. http://crbug.com/413034.
217 repack("repack_ui_test_mac_locale_pack") { 217 repack("repack_ui_test_mac_locale_pack") {
218 visibility = [ 218 visibility = [ ":ui_test_pak" ]
219 ":ui_test_pak",
220 "//:gn_visibility", # TODO(GYP): this shouldn't be necessary.
221 ]
222 219
223 sources = [ 220 sources = [
224 "$root_gen_dir/ui/strings/app_locale_settings_en-US.pak", 221 "$root_gen_dir/ui/strings/app_locale_settings_en-US.pak",
225 "$root_gen_dir/ui/strings/ui_strings_en-US.pak", 222 "$root_gen_dir/ui/strings/ui_strings_en-US.pak",
226 ] 223 ]
227 224
228 output = "$root_out_dir/ui/en.lproj/locale.pak" 225 output = "$root_out_dir/ui/en.lproj/locale.pak"
229 226
230 deps = [ 227 deps = [
231 "//ui/strings", 228 "//ui/strings",
232 ] 229 ]
233 } 230 }
OLDNEW
« ui/gl/BUILD.gn ('K') | « ui/ozone/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698