Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: testing/test.gni

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================================================== 5 # ==============================================================================
6 # TEST SETUP 6 # TEST SETUP
7 # ============================================================================== 7 # ==============================================================================
8 8
9 template("_gen_isolate") { 9 template("_gen_isolate") {
10 testonly = true 10 testonly = true
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 deps = [ 253 deps = [
254 ":$_test_runner_target", 254 ":$_test_runner_target",
255 ] 255 ]
256 if (_use_raw_android_executable) { 256 if (_use_raw_android_executable) {
257 deps += [ ":$_dist_target" ] 257 deps += [ ":$_dist_target" ]
258 } else { 258 } else {
259 deps += [ ":$_apk_target" ] 259 deps += [ ":$_apk_target" ]
260 } 260 }
261 } 261 }
262 262
263 # TODO(GYP): Delete this after we've converted everything to GN. 263 # TODO(GYP_GONE): Delete this after we've converted everything to GN.
264 # The _run targets exist only for compatibility w/ GYP. 264 # The _run targets exist only for compatibility w/ GYP.
265 group("${target_name}_apk_run") { 265 group("${target_name}_apk_run") {
266 testonly = true 266 testonly = true
267 deps = [ 267 deps = [
268 ":${invoker.target_name}", 268 ":${invoker.target_name}",
269 ] 269 ]
270 } 270 }
271 } else if (is_ios) { 271 } else if (is_ios) {
272 import("//build/config/ios/rules.gni") 272 import("//build/config/ios/rules.gni")
273 273
274 _test_target = target_name 274 _test_target = target_name
275 _resources_bundle_data = target_name + "_resources_bundle_data" 275 _resources_bundle_data = target_name + "_resources_bundle_data"
276 276
277 bundle_data(_resources_bundle_data) { 277 bundle_data(_resources_bundle_data) {
278 visibility = [ 278 visibility = [
279 ":${_test_target}", 279 ":${_test_target}",
280 ":${_test_target}_generate_executable", 280 ":${_test_target}_generate_executable",
281 ] 281 ]
282 sources = [ 282 sources = [
283 "//testing/gtest_ios/Default.png", 283 "//testing/gtest_ios/Default.png",
284 ] 284 ]
285 outputs = [ 285 outputs = [
286 "{{bundle_resources_dir}}/{{source_file_part}}", 286 "{{bundle_resources_dir}}/{{source_file_part}}",
287 ] 287 ]
288 } 288 }
289 289
290 ios_app_bundle(_test_target) { 290 ios_app_bundle(_test_target) {
291 # TODO(GYP): Make this configurable and only provide a default 291 # TODO: Make this configurable and only provide a default that can be
292 # that can be overridden. 292 # overridden.
293 info_plist = "//testing/gtest_ios/unittest-Info.plist" 293 info_plist = "//testing/gtest_ios/unittest-Info.plist"
294 app_name = target_name 294 app_name = target_name
295 entitlements_path = "//testing/gtest_ios" 295 entitlements_path = "//testing/gtest_ios"
296 code_signing_identity = "" 296 code_signing_identity = ""
297 testonly = true 297 testonly = true
298 extra_substitutions = [ "BUNDLE_ID_TEST_NAME=$app_name" ] 298 extra_substitutions = [ "BUNDLE_ID_TEST_NAME=$app_name" ]
299 299
300 # See above call. 300 # See above call.
301 set_sources_assignment_filter([]) 301 set_sources_assignment_filter([])
302 302
(...skipping 19 matching lines...) Expand all
322 deps += [ 322 deps += [
323 # All shared libraries must have the sanitizer deps to properly link in 323 # All shared libraries must have the sanitizer deps to properly link in
324 # asan mode (this target will be empty in other cases). 324 # asan mode (this target will be empty in other cases).
325 "//build/config/sanitizers:deps", 325 "//build/config/sanitizers:deps",
326 326
327 # Give tests the default manifest on Windows (a no-op elsewhere). 327 # Give tests the default manifest on Windows (a no-op elsewhere).
328 "//build/win:default_exe_manifest", 328 "//build/win:default_exe_manifest",
329 ] 329 ]
330 } 330 }
331 331
332 # TODO(GYP): Delete this after we've converted everything to GN. 332 # TODO(GYP_GONE): Delete this after we've converted everything to GN.
333 # The _run targets exist only for compatibility with GYP. 333 # The _run targets exist only for compatibility with GYP.
334 group("${target_name}_run") { 334 group("${target_name}_run") {
335 testonly = true 335 testonly = true
336 deps = [ 336 deps = [
337 ":${invoker.target_name}", 337 ":${invoker.target_name}",
338 ] 338 ]
339 } 339 }
340 340
341 if (defined(invoker.output_name) && target_name != invoker.output_name) { 341 if (defined(invoker.output_name) && target_name != invoker.output_name) {
342 group("${invoker.output_name}_run") { 342 group("${invoker.output_name}_run") {
343 testonly = true 343 testonly = true
344 deps = [ 344 deps = [
345 ":${invoker.target_name}", 345 ":${invoker.target_name}",
346 ] 346 ]
347 } 347 }
348 } 348 }
349 } 349 }
350 } 350 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698