Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Side by Side Diff: build/config/BUILDCONFIG.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================================================= 5 # =============================================================================
6 # PLATFORM SELECTION 6 # PLATFORM SELECTION
7 # ============================================================================= 7 # =============================================================================
8 # 8 #
9 # There are two main things to set: "os" and "cpu". The "toolchain" is the name 9 # There are two main things to set: "os" and "cpu". The "toolchain" is the name
10 # of the GN thing that encodes combinations of these things. 10 # of the GN thing that encodes combinations of these things.
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 # support this? 163 # support this?
164 host_toolchain = "//build/toolchain/linux:clang_$host_cpu" 164 host_toolchain = "//build/toolchain/linux:clang_$host_cpu"
165 } else if (is_clang) { 165 } else if (is_clang) {
166 host_toolchain = "//build/toolchain/linux:clang_$host_cpu" 166 host_toolchain = "//build/toolchain/linux:clang_$host_cpu"
167 } else { 167 } else {
168 host_toolchain = "//build/toolchain/linux:$host_cpu" 168 host_toolchain = "//build/toolchain/linux:$host_cpu"
169 } 169 }
170 } else if (host_os == "mac") { 170 } else if (host_os == "mac") {
171 host_toolchain = "//build/toolchain/mac:clang_$host_cpu" 171 host_toolchain = "//build/toolchain/mac:clang_$host_cpu"
172 } else if (host_os == "win") { 172 } else if (host_os == "win") {
173 # TODO(crbug.com/467159): win cross-compiles don't actually work yet, so 173 # On Windows always use the target CPU for host builds. On the
174 # use the target_cpu instead of the host_cpu. 174 # configurations we support this will always work and it saves build steps.
175 if (is_clang) { 175 if (is_clang) {
176 host_toolchain = "//build/toolchain/win:clang_$target_cpu" 176 host_toolchain = "//build/toolchain/win:clang_$target_cpu"
177 } else { 177 } else {
178 host_toolchain = "//build/toolchain/win:$target_cpu" 178 host_toolchain = "//build/toolchain/win:$target_cpu"
179 } 179 }
180 } else { 180 } else {
181 assert(false, "Unsupported host_os: $host_os") 181 assert(false, "Unsupported host_os: $host_os")
182 } 182 }
183 } 183 }
184 184
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 forward_variables_from(invoker, "*", [ "visibility" ]) 620 forward_variables_from(invoker, "*", [ "visibility" ])
621 621
622 # All shared libraries must have the sanitizer deps to properly link in 622 # All shared libraries must have the sanitizer deps to properly link in
623 # asan mode (this target will be empty in other cases). 623 # asan mode (this target will be empty in other cases).
624 if (!defined(deps)) { 624 if (!defined(deps)) {
625 deps = [] 625 deps = []
626 } 626 }
627 deps += [ "//build/config/sanitizers:deps" ] 627 deps += [ "//build/config/sanitizers:deps" ]
628 } 628 }
629 } 629 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698