Fix issue 21587, a regression of CL 196020....

Fix issue 21587, a regression of CL 196020.

This CL fixes issue 21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input.

It's a regression of my CL: http://codereview.chromium.org/196020, which reverts the text of omnibox in OnAfterPossibleChanges(), when enter key is pressed:

...
  // If the change is caused by an Enter key press event, and the event was not
  // handled by IME, then it's an unexpected change and shall be reverted here.
  // {Start|Finish}UpdatingHighlightedText() are called here to prevent the
  // PRIMARY selection from being changed.
  if (enter_was_pressed_ &&
      (char_inserted_ == '\n' || char_inserted_ == '\r')) {
    StartUpdatingHighlightedText();
    SetTextAndSelectedRange(text_before_change_, sel_before_change_);
    FinishUpdatingHighlightedText();
    return false;
  }
...

Unfortunately, this piece of code causes the char_inserted_ to be set to wrong value in HandleInsertText(), if the text has only one character. See the source code of HandleInsertText():

...
  // Filter out new line and tab characters.
  // |text| is guaranteed to be a valid UTF-8 string, so it's safe here to
  // filter byte by byte.
  //
  // If there was only a single character, then it might be generated by a key
  // event. In this case, we save the single character to help our
  // "key-press-event" signal handler distinguish if an Enter key event is
  // handled by IME or not.
  if (len == 1)
    char_inserted_ = text[0];
...

This CL uses a boolean |enter_was_inserted_| instead of char |char_inserted_| to record the enter key status, to make sure it won't be reset unexpectly.

The test has been updated to cover this case. An unexpected dns lookup issue in the test which causes a failure on Windows was also fixed.

BUG=21587
: REGRESSION: Omnibox does nothing when pressing enter after a single character of input.
TEST=Input one character in omnibox and press enter, the default link matched with the character should be opened.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26315

[James Su, 2009-09-15 04:27:42]

Please help review this CL. So sorry for causing so many regression issues in
this piece of code. I'll continue to update
autocomplete_edit_view_browsertest.cc to cover more cases.

Regards
James Su

[Evan Martin, 2009-09-15 16:22:03]

LGTM

http://codereview.chromium.org/200131/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc (right):

http://codereview.chromium.org/200131/diff/1/2#newcode426
Line 426: // Test Enter to search a single character.
This comment is a bit confusing, it makes it sound like you're testing that
pressing enter causes a single character search.
Maybe
"Test that entering a single character then Enter performs a search."

[Peter Kasting, 2009-09-15 17:14:34]

I don't understand this code, so I can't review.  I'm leaving it in Evan's
hands.

[James Su, 2009-09-16 01:22:46]

This CL has been submitted.

Thanks.
James Su

http://codereview.chromium.org/200131/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc (right):

http://codereview.chromium.org/200131/diff/1/2#newcode426
Line 426: // Test Enter to search a single character.
On 2009/09/15 16:22:03, Evan Martin wrote:
> This comment is a bit confusing, it makes it sound like you're testing that
> pressing enter causes a single character search.
> Maybe
> "Test that entering a single character then Enter performs a search."

Done.