Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001283002: Remove ViewProvider.CreateView()'s exposed_services. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
jeffbrown
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -82 lines) Patch
M apps/moterm/moterm_app.h View 1 chunk +1 line, -2 lines 0 comments Download
M apps/moterm/moterm_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M examples/shadows/shadows_app.h View 1 chunk +1 line, -2 lines 0 comments Download
M examples/shadows/shadows_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/jank/jank.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/noodles/noodles_app.h View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/noodles/noodles_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/pdf_viewer/pdf_viewer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/png_viewer/png_viewer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/shapes/shapes_app.h View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/shapes/shapes_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/spinning_cube/spinning_cube_app.h View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/spinning_cube/spinning_cube_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/tile/tile_app.h View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/tile/tile_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ui/tile/tile_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart View 8 chunks +7 lines, -21 lines 0 comments Download
M mojo/services/ui/views/interfaces/view_provider.mojom View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/ui/view_provider_app.h View 2 chunks +4 lines, -10 lines 0 comments Download
M mojo/ui/view_provider_app.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M services/ui/launcher/launch_instance.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-23 19:12:29 UTC) #1
jeffbrown
lgtm
4 years, 7 months ago (2016-05-24 20:06:49 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-24 20:16:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
db06898a53770ff272c75ba012a757597fc0e2c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698