Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2001233002: Cherry-picking hangouts.google.com whitelisting change into M51 (Closed)

Created:
4 years, 7 months ago by AlexZ
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Cherry-picking hangouts.google.com whitelisting change into M51. Urgent: whitelist hangouts.google.com further (should've been done in issue 1552383002 from Dec 2015, but...) to allow video effects plugin access; tag on meet.google.com for a similar purpose; tax: refactor whitelist checks into separate thing. R=sshruthi@chromium.org,govind@chromium.org,sky@chromium.org,tsepez@chromium.org BUG=614062 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1974413003 Cr-Commit-Position: refs/heads/master@{#395172} (cherry picked from commit 81dcbd6123178d58c5edc53d1453e03f9afa31ca)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -123 lines) Patch
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/renderer/app_categorizer.h View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/renderer/app_categorizer.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A chrome/renderer/app_categorizer_unittest.cc View 1 chunk +125 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 4 chunks +10 lines, -53 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 6 chunks +23 lines, -70 lines 0 comments Download

Messages

Total messages: 30 (17 generated)
qaz-chromium
Since I don't have commit permission, git-drover failed due to access error. Would I be ...
4 years, 7 months ago (2016-05-23 18:25:11 UTC) #3
chromium-reviews
Shruthi, could you please answer this? On Mon, May 23, 2016 at 11:25 AM, <qaz@chromium.org> ...
4 years, 7 months ago (2016-05-23 18:53:03 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001233002/1
4 years, 7 months ago (2016-05-23 20:20:02 UTC) #9
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 7 months ago (2016-05-23 20:20:05 UTC) #11
qaz-chromium
sky@ and tsepez@, could you approve this cherry-pick? I'd like to get this in by ...
4 years, 7 months ago (2016-05-23 20:26:42 UTC) #14
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-23 20:27:57 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001233002/1
4 years, 7 months ago (2016-05-23 20:29:45 UTC) #17
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 7 months ago (2016-05-23 20:29:47 UTC) #19
sky
LGTM
4 years, 7 months ago (2016-05-23 20:30:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001233002/1
4 years, 7 months ago (2016-05-23 20:31:25 UTC) #22
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-23 20:31:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001233002/1
4 years, 7 months ago (2016-05-23 20:35:08 UTC) #28
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 20:37:47 UTC) #30
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698