Make the invisible items in the system menu of a few Indian language versions...

Make the invisible items in the system menu of a few Indian language versions of Chrome.

|owner_drawn| is currently set if the UI font family or the UI font size is overriden. However, this leads menu items to be invisible in the system menu. This was not the case in Chrome 2.0, but somehow the way 'owner_drawn' menu is drawn has changed and we have this regression. 

As a work around for the branch (3.0 train left, but we can merge this to 3.0.1), this CL sets |owner_drawn| to false for the system menu even if the UI font or the UI font size is overriden. 

BUG=18042
(http://crbug.com/18042 )
TEST=Run Chrome with '--lang=hi' command line flag on Windows. Make sure that the translated menu items in the system menu are visible (e.g. 'New Tab', 'Task Manager') although a bit too small to read while the font size in the page/wrench menu is reasonably large. 

Commited: http://src.chromium.org/viewvc/chrome?view=rev&revision=27382

[jungshik at Google, 2009-09-17 00:10:15]

ping :-)

We want to merge this to 3.0.1 after baking in the trunk for a while.

[jungshik at Google, 2009-09-24 20:19:20]

Asking Finnur for review :-)

[Finnur, 2009-09-24 21:14:53]

http://codereview.chromium.org/200123/diff/1/2
File views/controls/menu/native_menu_win.cc (right):

http://codereview.chromium.org/200123/diff/1/2#newcode306
Line 306: !system_menu_for),
I understand that you don't want the menu to be owner drawn, but when exactly do
you expect |system_menu_for| to be NULL? It is non-NULL when I test this on
Vista with lang=hi and lang=ml, so why not just change this back to:
  owner_draw_(false)
which is how it used to be? Isn't that effectively the same?

[jungshik at Google, 2009-09-25 02:08:31]

On 2009/09/24 21:14:53, Finnur wrote:
> http://codereview.chromium.org/200123/diff/1/2
> File views/controls/menu/native_menu_win.cc (right):
> 
> http://codereview.chromium.org/200123/diff/1/2#newcode306
> Line 306: !system_menu_for),
> I understand that you don't want the menu to be owner drawn, but when exactly
do
> you expect |system_menu_for| to be NULL? It is non-NULL when I test this on
> Vista with lang=hi and lang=ml, so why not just change this back to:
>   owner_draw_(false)
> which is how it used to be? Isn't that effectively the same?

As I explained over gtalk, |system_menu_for| is only true when it's for the
system menu (as its name implies).  

As for just setting owner_drawn to false vs what I'm doing, I just checked on
Vista and there is a font size difference between two in non-system menus (page,
wrench menu, etc) for Hindi and Malayalam Chrome as it should be the case. 

With Hindi Chrome, it's easy to miss the difference because the font size ratio
is 1.25 which can be translated into 1 or 2 px difference. However, even for
Hindi Chrome, there's a difference. 
With Malayalam Chrome, the difference is more prominent.

[Finnur, 2009-09-25 02:53:57]

LG

On 2009/09/25 02:08:31, Jungshik Shin wrote:
> On 2009/09/24 21:14:53, Finnur wrote:
> > http://codereview.chromium.org/200123/diff/1/2
> > File views/controls/menu/native_menu_win.cc (right):
> > 
> > http://codereview.chromium.org/200123/diff/1/2#newcode306
> > Line 306: !system_menu_for),
> > I understand that you don't want the menu to be owner drawn, but when
exactly
> do
> > you expect |system_menu_for| to be NULL? It is non-NULL when I test this on
> > Vista with lang=hi and lang=ml, so why not just change this back to:
> >   owner_draw_(false)
> > which is how it used to be? Isn't that effectively the same?
> 
> As I explained over gtalk, |system_menu_for| is only true when it's for the
> system menu (as its name implies).  
> 
> As for just setting owner_drawn to false vs what I'm doing, I just checked on
> Vista and there is a font size difference between two in non-system menus
(page,
> wrench menu, etc) for Hindi and Malayalam Chrome as it should be the case. 
> 
> With Hindi Chrome, it's easy to miss the difference because the font size
ratio
> is 1.25 which can be translated into 1 or 2 px difference. However, even for
> Hindi Chrome, there's a difference. 
> With Malayalam Chrome, the difference is more prominent.