src/core/SkEndian.h - Issue 2001203003: Write ICC profiles from SkColorSpace object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkEndian.h

Issue 2001203003: Write ICC profiles from SkColorSpace object (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkEndian.h

diff --git a/src/core/SkEndian.h b/src/core/SkEndian.h

index 954afb046d913aac5d07982a73e292d3003e0ef0..39e5dd8fb4372689a3338913d284d977c64c2e5d 100644

--- a/src/core/SkEndian.h

+++ b/src/core/SkEndian.h

@@ -50,7 +50,7 @@ static inline void SkEndianSwap16s(uint16_t array[], int count) {

/** Reverse all 4 bytes in a 32bit value.

e.g. 0x12345678 -> 0x78563412

-static inline uint32_t SkEndianSwap32(uint32_t value) {

+static constexpr uint32_t SkEndianSwap32(uint32_t value) {

return ((value & 0xFF) << 24) |

((value & 0xFF00) << 8) |

((value & 0xFF0000) >> 8) |