Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2001173003: Roll chromium_revision 1d144ca7f86..2a818f5413 (375480:395512) (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
CC:
nisse-chromium (ooo August 14)
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Roll chromium_revision 1d144ca7f86..2a818f5413 (375480:395512) * Update gflags to newer repository location (plain copy from the files in WebRTC). * Add workarounds for mojo dependency (see http://bugs.webrtc.org/5629 for more details). * Update libyuv_unittest to generate user friendly run-scripts for Android in out/{Debug,Release}/bin * Fix Android test execution by adding explicit dependency on Chromium's base/base.gyp:base_build_config_gen This roll also solves the compile problem for Mac ASan bots. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca7f86..2a818f5413 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca7f86..2a818f5413 R=magjed@chromium.org TBR=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/b6bfacc2e735f4dd289e658c9cbac4d7ceb55e03

Patch Set 1 #

Patch Set 2 : Updated gflags with WebRTC's copy and worked around mojo issue #

Patch Set 3 : Updated android test #

Patch Set 4 : Fixed Android test execution #

Patch Set 5 : Restored license headers for gflag build configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1043 lines, -620 lines) Patch
M .gitignore View 1 2 2 chunks +12 lines, -3 lines 0 comments Download
M DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libyuv_test.gyp View 1 2 3 1 chunk +11 lines, -1 line 0 comments Download
M setup_links.py View 1 2 4 chunks +3 lines, -6 lines 0 comments Download
M third_party/gflags/BUILD.gn View 1 2 3 4 2 chunks +16 lines, -8 lines 0 comments Download
M third_party/gflags/README.libyuv View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/gflags/gen/posix/include/gflags/gflags.h View 1 22 chunks +159 lines, -178 lines 0 comments Download
M third_party/gflags/gen/posix/include/gflags/gflags_completions.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A third_party/gflags/gen/posix/include/gflags/gflags_declare.h View 1 1 chunk +141 lines, -0 lines 0 comments Download
A third_party/gflags/gen/posix/include/gflags/gflags_gflags.h View 1 1 chunk +101 lines, -0 lines 0 comments Download
M third_party/gflags/gen/posix/include/private/config.h View 1 1 chunk +85 lines, -83 lines 0 comments Download
M third_party/gflags/gen/win/include/gflags/gflags.h View 1 23 chunks +150 lines, -184 lines 0 comments Download
M third_party/gflags/gen/win/include/gflags/gflags_completions.h View 1 3 chunks +7 lines, -16 lines 0 comments Download
A third_party/gflags/gen/win/include/gflags/gflags_declare.h View 1 1 chunk +141 lines, -0 lines 0 comments Download
A third_party/gflags/gen/win/include/gflags/gflags_gflags.h View 1 1 chunk +101 lines, -0 lines 0 comments Download
M third_party/gflags/gen/win/include/private/config.h View 1 1 chunk +83 lines, -110 lines 0 comments Download
M third_party/gflags/gflags.gyp View 1 2 3 4 3 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
kjellander_chromium
Woho, this fixes a lot of issues and rolls in 20k of Chromium revisions.
4 years, 7 months ago (2016-05-24 09:19:59 UTC) #11
magjed_chromium
lgtm, although I don't know the third_party/gflags/ parts. This CL fixes libyuv_unittest on Android, right? ...
4 years, 7 months ago (2016-05-24 09:33:15 UTC) #12
kjellander_chromium
On 2016/05/24 09:33:15, magjed_chromium wrote: > lgtm, although I don't know the third_party/gflags/ parts. > ...
4 years, 7 months ago (2016-05-24 09:40:47 UTC) #14
kjellander_chromium
Committed patchset #5 (id:80001) manually as b6bfacc2e735f4dd289e658c9cbac4d7ceb55e03 (presubmit successful).
4 years, 7 months ago (2016-05-24 09:41:10 UTC) #16
fbarchard1
4 years, 7 months ago (2016-05-24 17:56:21 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698