Issue 200116: Fix bug where content scripts can get GC'd if they don't attach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200116: Fix bug where content scripts can get GC'd if they don't attach (Closed)

Created:
11 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix bug where content scripts can get GC'd if they don't attach to any DOM events. BUG=17410 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26136

Patch Set 2 : remove extra braces #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -5 lines)			Patch
M	chrome/renderer/extensions/bindings_utils.h	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/bindings_utils.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	1	4 chunks	+15 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

woohoo! lgtm http://codereview.chromium.org/200116/diff/1004/7 File chrome/renderer/extensions/event_bindings.cc (right): http://codereview.chromium.org/200116/diff/1004/7#newcode86 Line 86: bool allow_api = has_permission; may as ...

11 years, 3 months ago (2009-09-14 18:07:46 UTC) #2

Aaron Boodman

11 years, 3 months ago (2009-09-14 18:59:33 UTC) #3

On 2009/09/14 18:07:46, Matt Perry wrote:
> http://codereview.chromium.org/200116/diff/1004/7#newcode121
> Line 121: if (current_context_info &&
> why the NULL-check here but not in AttachEvent?

Because in the case where the context got GC'd, we have already removed context
info from the list at this point (in UnregisterContext).

Expand Messages | Collapse Messages

Issue 200116: Fix bug where content scripts can get GC'd if they don't attach (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove extra braces #

Messages