Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: tools/viewer/sk_app/android/surface_glue_android.cpp

Issue 2001153002: Move inval dedup to Window for wider usages. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/viewer/sk_app/android/surface_glue_android.cpp
diff --git a/tools/viewer/sk_app/android/surface_glue_android.cpp b/tools/viewer/sk_app/android/surface_glue_android.cpp
index 3a4fca539c8204489e381c4b6cba7c0fc0c261c6..06701902c4247a425efa87a8ddb01b12ee682eab 100644
--- a/tools/viewer/sk_app/android/surface_glue_android.cpp
+++ b/tools/viewer/sk_app/android/surface_glue_android.cpp
@@ -71,8 +71,12 @@ void SkiaAndroidApp::setTitle(const char* title) const {
}
void SkiaAndroidApp::paintIfNeeded() {
- if (fNativeWindow && fWindow) {
- fWindow->onPaint();
+ if (fWindow) {
+ if (fNativeWindow) {
+ fWindow->onPaint();
+ } else {
+ fWindow->uncheckInval();
+ }
}
}
@@ -86,14 +90,6 @@ void SkiaAndroidApp::readMessage(Message* message) const {
SkASSERT(readSize == sizeof(Message));
}
-void SkiaAndroidApp::inval() {
- SkAutoMutexAcquire ama(fMutex);
- if (!fIsContentInvalidated) {
- postMessage(Message(kContentInvalidated));
- fIsContentInvalidated = true;
- }
-}
-
int SkiaAndroidApp::message_callback(int fd, int events, void* data) {
auto skiaAndroidApp = (SkiaAndroidApp*)data;
Message message;
@@ -108,8 +104,6 @@ int SkiaAndroidApp::message_callback(int fd, int events, void* data) {
return 0;
}
case kContentInvalidated: {
- SkAutoMutexAcquire ama(skiaAndroidApp->fMutex);
- skiaAndroidApp->fIsContentInvalidated = false;
skiaAndroidApp->paintIfNeeded();
break;
}
« tools/viewer/sk_app/Window.h ('K') | « tools/viewer/sk_app/android/surface_glue_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698