Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2001133004: [tools/perf] MemoryLongRunningIdleGmailBackground requires tabs (Closed)

Created:
4 years, 7 months ago by perezju
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] MemoryLongRunningIdleGmailBackground requires tabs Only enable this benchmark on browsers with tabs. BUG=612210 Committed: https://crrev.com/6527cb61eb4944d09315c62ac22a78e139a87f36 Cr-Commit-Position: refs/heads/master@{#395626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/memory_infra.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
perezju
4 years, 7 months ago (2016-05-24 10:29:14 UTC) #3
perezju
I've manually double-checked that this keeps the benchmark disabled for android-webview.
4 years, 7 months ago (2016-05-24 10:31:50 UTC) #4
ulan
LGTM, thank you!
4 years, 7 months ago (2016-05-24 10:35:33 UTC) #5
nednguyen
lgtm
4 years, 7 months ago (2016-05-24 13:06:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001133004/1
4 years, 7 months ago (2016-05-24 13:11:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-05-24 17:17:29 UTC) #10
nednguyen
On 2016/05/24 17:17:29, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-05-24 17:20:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001133004/1
4 years, 6 months ago (2016-05-24 17:21:01 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-24 17:26:22 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-24 17:28:00 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6527cb61eb4944d09315c62ac22a78e139a87f36
Cr-Commit-Position: refs/heads/master@{#395626}

Powered by Google App Engine
This is Rietveld 408576698