Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001133003: Flip linux_nacl_sdk* bots to GN (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
bradnelson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_browser_side_nav
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip linux_nacl_sdk* bots to GN R=bradnelson@chromium.org BUG=605732 Committed: https://crrev.com/02eac1e1f7a1f61ae63d7f6cea545920e0eafb8a Cr-Commit-Position: refs/heads/master@{#395746}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Dirk Pranke
It looks like this + https://codereview.chromium.org/2006163003/ should mostly flip these two bots to GN, but ...
4 years, 7 months ago (2016-05-24 02:03:51 UTC) #1
bradnelson
lgtm
4 years, 7 months ago (2016-05-24 22:27:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001133003/20001
4 years, 7 months ago (2016-05-24 22:28:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 00:13:34 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 00:14:31 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/02eac1e1f7a1f61ae63d7f6cea545920e0eafb8a
Cr-Commit-Position: refs/heads/master@{#395746}

Powered by Google App Engine
This is Rietveld 408576698