Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2001133002: [deoptimizer] Fix materialization of sloppy arguments. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Fix materialization of sloppy arguments. This makes sure the deoptimizer can materialize sloppy arguments objects with the FAST_SLOPPY_ARGUMENTS_ELEMENTS elements kind. TurboFan's escape analysis treates those as normal JSObject types and hence materializes them differently than Crankshaft does. R=verwaest@chromium.org TEST=mjsunit/regress/regress-crbug-613919 BUG=chromium:613919 Committed: https://crrev.com/3cc2adb3195afe8f6eb671664bd65828eb68adb1 Cr-Commit-Position: refs/heads/master@{#36440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M src/deoptimizer.cc View 1 chunk +6 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-613919.js View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
I ended up handling the sloppy arguments case in the deoptimizer itself. It turns out ...
4 years, 7 months ago (2016-05-23 13:08:13 UTC) #1
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-23 13:48:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001133002/1
4 years, 7 months ago (2016-05-23 13:48:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 13:50:58 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 13:52:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cc2adb3195afe8f6eb671664bd65828eb68adb1
Cr-Commit-Position: refs/heads/master@{#36440}

Powered by Google App Engine
This is Rietveld 408576698