Issue 200113002: Fix for issue 351261.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200113002: Fix for issue 351261. (Closed)

Created:
6 years, 9 months ago by mvstanton

Modified:
6 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix for issue 351261. This relands the following fix: "HAllocate should never generate allocation code if the requested size does not fit into page. Regression test included. (bug 347543)" along with additional fixes to KeyedStoreIC. BUG=351261 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19926

Patch Set 1 #

Patch Set 2 : Fixed comment. #

Patch Set 3 : Added test. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -18 lines)			Patch
M	src/a64/lithium-codegen-a64.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ic.cc	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-351261.js	View	1 2	1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Toon, here is the issue we discussed, PTAL, thx! --Michael

6 years, 9 months ago (2014-03-14 10:17:07 UTC) #1

mvstanton

6 years, 9 months ago (2014-03-14 10:23:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r19926 (presubmit successful).

Expand Messages | Collapse Messages