Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 200110: Fix some mixed content layout tests.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews_googlegroups.com, jam, brettw, pam+watch_chromium.org
Visibility:
Public.

Description

Fix some mixed content layout tests. 1. Make test shell ignore certificate errors. 2. Extend WebFrameClient for new notifications and printf these. R=abarth BUG=21644 TEST=covered by layout tests

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M chrome/renderer/render_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/api/public/WebFrameClient.h View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/glue/empty_webframeclient.h View 1 chunk +3 lines, -0 lines 1 comment Download
M webkit/glue/webframeloaderclient_impl.cc View 1 chunk +7 lines, -1 line 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
11 years, 3 months ago (2009-09-12 00:08:28 UTC) #1
abarth-chromium
LGTM http://codereview.chromium.org/200110/diff/4001/4007 File webkit/glue/empty_webframeclient.h (right): http://codereview.chromium.org/200110/diff/4001/4007#newcode85 Line 85: WebKit::WebFrame* frame, const WebKit::WebString& security_origin) {} I ...
11 years, 3 months ago (2009-09-12 05:37:00 UTC) #2
darin (slow to review)
11 years, 3 months ago (2009-09-14 16:19:15 UTC) #3
> I take it you decided against passing a WebSecurityOrigin here.

WebSecurityOrigin doesn't exist yet.  I plan to go back and add that class
later.  There are other places in WebKit API where "security origin" is passed
as a string, so it seemed out-of-scope to create WebSecurityOrigin as part of
this CL.

Powered by Google App Engine
This is Rietveld 408576698