Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2001093008: Cleanup: Pass std::string as const reference from testing/ (Closed)

Created:
4 years, 7 months ago by ki.stfu
Modified:
4 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Pass std::string as const reference from testing/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=phajdan.jr@chromium.org Committed: https://crrev.com/a690281b4838171d8391e0804e3354a857fb28e1 Cr-Commit-Position: refs/heads/master@{#396030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/multiprocess_func_list.h View 1 chunk +1 line, -1 line 0 comments Download
M testing/multiprocess_func_list.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ki.stfu
4 years, 7 months ago (2016-05-25 17:19:24 UTC) #1
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-25 19:44:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001093008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001093008/1
4 years, 7 months ago (2016-05-25 21:21:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 23:07:21 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:08:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a690281b4838171d8391e0804e3354a857fb28e1
Cr-Commit-Position: refs/heads/master@{#396030}

Powered by Google App Engine
This is Rietveld 408576698