[Cronet] Add version and headers to CronetFramework package

Add version and headers to CronetFramework package

BUG=611176
Committed: https://crrev.com/d33fbe962870314d133891081d57df7fd558a826
Cr-Commit-Position: refs/heads/master@{#395954}

[kapishnikov, 2016-05-25 14:38:33]

Description was changed from

==========
Add version and headers to CronetFramework package
==========

to

==========
Add version and headers to CronetFramework package

This CL changes the Cronet framework package structure so it is the same as in
Google3. See https://critique.corp.google.com/#review/123120221
==========

[kapishnikov, 2016-05-25 14:38:33]

kapishnikov@chromium.org changed reviewers:
+ mef@chromium.org

[kapishnikov, 2016-05-25 17:22:36]

Description was changed from

==========
Add version and headers to CronetFramework package

This CL changes the Cronet framework package structure so it is the same as in
Google3. See https://critique.corp.google.com/#review/123120221
==========

to

==========
Add version and headers to CronetFramework package


BUG=611176
==========

[mef, 2016-05-25 17:55:31]

lgtm

https://codereview.chromium.org/2001093007/diff/1/components/cronet/tools/pac...
File components/cronet/tools/package_ios.py (right):

https://codereview.chromium.org/2001093007/diff/1/components/cronet/tools/pac...
components/cronet/tools/package_ios.py:83:
shutil.copy2('components/cronet/ios/cronet_c_for_grpc.h', headers_dir)
Could / should those copies come from Framework directory instead of source?

[kapishnikov, 2016-05-25 18:12:53]

https://codereview.chromium.org/2001093007/diff/1/components/cronet/tools/pac...
File components/cronet/tools/package_ios.py (right):

https://codereview.chromium.org/2001093007/diff/1/components/cronet/tools/pac...
components/cronet/tools/package_ios.py:83:
shutil.copy2('components/cronet/ios/cronet_c_for_grpc.h', headers_dir)
On 2016/05/25 17:55:31, mef wrote:
> Could / should those copies come from Framework directory instead of source?

Done.

[kapishnikov, 2016-05-25 18:14:15]

The CQ bit was checked by kapishnikov@chromium.org

[kapishnikov, 2016-05-25 18:14:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org
Link to the patchset: https://codereview.chromium.org/2001093007/#ps20001
(title: "Copy headers from Framework dir instead of source")

[kapishnikov, 2016-05-25 18:14:53]

The CQ bit was unchecked by kapishnikov@chromium.org

[kapishnikov, 2016-05-25 18:14:57]

The CQ bit was checked by kapishnikov@chromium.org

[commit-bot: I haz the power, 2016-05-25 18:15:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001093007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001093007/20001

[commit-bot: I haz the power, 2016-05-25 19:13:50]

Description was changed from

==========
Add version and headers to CronetFramework package


BUG=611176
==========

to

==========
Add version and headers to CronetFramework package


BUG=611176
==========

[commit-bot: I haz the power, 2016-05-25 19:13:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 19:16:31]

Description was changed from

==========
Add version and headers to CronetFramework package


BUG=611176
==========

to

==========
Add version and headers to CronetFramework package

BUG=611176

Committed: https://crrev.com/d33fbe962870314d133891081d57df7fd558a826
Cr-Commit-Position: refs/heads/master@{#395954}
==========

[commit-bot: I haz the power, 2016-05-25 19:16:32]

Patchset 2 (id:??) landed as
https://crrev.com/d33fbe962870314d133891081d57df7fd558a826
Cr-Commit-Position: refs/heads/master@{#395954}