Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001093002: Revert of Remove enable_topchrome_md build flag (Closed)

Created:
4 years, 7 months ago by kolos1
Modified:
4 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, oshima+watch_chromium.org, wfh+watch_chromium.org, chromium-apps-reviews_chromium.org, Michael Moss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove enable_topchrome_md build flag (patchset #5 id:80001 of https://codereview.chromium.org/1991573002/ ) Reason for revert: Linux builder failing (isolated tests). https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29?numbuilds=100 https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/101069 Tests failed because of missing chrome_material_100_percent.pak. Original issue's description: > Remove enable_topchrome_md build flag > > Actually use of MD is still controlled by a runtime flag. > > Also get rid of Material Design resource build step (on !osx). These drop-in png replacements are no longer used (they've all been converted to vectorized images). > > BUG=none > > Committed: https://crrev.com/2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5 > Cr-Commit-Position: refs/heads/master@{#395146} TBR=thestig@chromium.org,varkha@chromium.org,scottmg@chromium.org,sky@chromium.org,blundell@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=613980 Committed: https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727 Cr-Commit-Position: refs/heads/master@{#395308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -34 lines) Patch
M build/common.gypi View 7 chunks +18 lines, -0 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/ui.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/app/theme/BUILD.gn View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser_tests.isolate View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/chrome_repack_chrome_material_100_percent.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_material_200_percent.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 3 chunks +26 lines, -10 lines 0 comments Download
M chrome/installer/linux/common/installer.include View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +9 lines, -0 lines 0 comments Download
M components/resources/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/resources/components_scaled_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
A components/resources/material_100_percent/omnibox/controlled_setting_mandatory.png View Binary file 0 comments Download
A components/resources/material_100_percent/omnibox/location_bar_http.png View Binary file 0 comments Download
A components/resources/material_100_percent/omnibox/omnibox_extension_app.png View Binary file 0 comments Download
A components/resources/material_100_percent/omnibox/omnibox_http.png View Binary file 0 comments Download
A components/resources/material_100_percent/omnibox/omnibox_search.png View Binary file 0 comments Download
A components/resources/material_200_percent/omnibox/controlled_setting_mandatory.png View Binary file 0 comments Download
A components/resources/material_200_percent/omnibox/location_bar_http.png View Binary file 0 comments Download
A components/resources/material_200_percent/omnibox/omnibox_extension_app.png View Binary file 0 comments Download
A components/resources/material_200_percent/omnibox/omnibox_http.png View Binary file 0 comments Download
A components/resources/material_200_percent/omnibox/omnibox_search.png View Binary file 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/material_design/material_design_controller.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/material_design/material_design_controller_unittest.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kolos1
Created Revert of Remove enable_topchrome_md build flag
4 years, 7 months ago (2016-05-23 11:00:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001093002/1
4 years, 7 months ago (2016-05-23 11:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001093002/1
4 years, 7 months ago (2016-05-23 11:01:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001093002/1
4 years, 7 months ago (2016-05-23 11:31:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001093002/1
4 years, 7 months ago (2016-05-23 12:01:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001093002/1
4 years, 7 months ago (2016-05-23 12:31:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 12:55:01 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 12:56:44 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/09b5d078e074eb8a89d0b0ffcfc4b6fb1e23b727
Cr-Commit-Position: refs/heads/master@{#395308}

Powered by Google App Engine
This is Rietveld 408576698