third_party/WebKit/Source/core/page/DragController.cpp - Issue 2001083002: Explicit management of FrameSelection availability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 2001083002: Explicit management of FrameSelection availability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-06-08T18:08:39 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/DragController.cpp

diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp

index 3b559f9366ee8eba8cf1cfd56db82e9e2adfc328..819283e3f69b83e1460c4d55018a57ad47d5a4f1 100644

--- a/third_party/WebKit/Source/core/page/DragController.cpp

+++ b/third_party/WebKit/Source/core/page/DragController.cpp

@@ -491,6 +491,13 @@ bool DragController::concludeEditDrag(DragData* dragData)

VisibleSelection dragCaret(m_page->dragCaretController().caretPosition());

m_page->dragCaretController().clear();

+ // |innerFrame| can be removed by event handler called by

+ // |dispatchTextInputEventFor()|.

+ if (!innerFrame->selection().isAvailable()) {

+ // "editing/pasteboard/drop-text-events-sideeffect-crash.html" reaches

+ // here.

+ return false;

+ }

Range* range = createRange(dragCaret.toNormalizedEphemeralRange());

Element* rootEditableElement = innerFrame->selection().rootEditableElement();