Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.h

Issue 2001083002: Explicit management of FrameSelection availability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-06-08T18:08:39 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionEditor.h
diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.h b/third_party/WebKit/Source/core/editing/SelectionEditor.h
index f3417cb7be47604311f75aec627584d86fde7b37..b24d494f97609b544441cec2b5e9ab08a3512e8e 100644
--- a/third_party/WebKit/Source/core/editing/SelectionEditor.h
+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.h
@@ -55,9 +55,11 @@ public:
void setVisibleSelection(const VisibleSelection&, FrameSelection::SetSelectionOptions);
void setVisibleSelection(const VisibleSelectionInFlatTree&, FrameSelection::SetSelectionOptions);
- void setIsDirectional(bool);
void setWithoutValidation(const Position& base, const Position& extent);
+ void documentAttached(Document*);
+ void documentDetached(const Document&);
+
// If this FrameSelection has a logical range which is still valid, this
// function return its clone. Otherwise, the return value from underlying
// |VisibleSelection|'s |firstRange()| is returned.
@@ -76,8 +78,13 @@ public:
private:
explicit SelectionEditor(FrameSelection&);
+ const Document& document() const;
LocalFrame* frame() const;
+ void clearVisibleSelection();
+ bool shouldAlwaysUseDirectionalSelection() const;
+
+ Member<Document> m_document;
Member<FrameSelection> m_frameSelection;
VisibleSelection m_selection;

Powered by Google App Engine
This is Rietveld 408576698