Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: src/ic/arm/ic-arm.cc

Issue 2001073002: [build] Fix a clang warning (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/disasm-ia32.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 827 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 // condition code uses at the patched jump. 838 // condition code uses at the patched jump.
839 int delta = Assembler::GetCmpImmediateRawImmediate(instr); 839 int delta = Assembler::GetCmpImmediateRawImmediate(instr);
840 delta += Assembler::GetCmpImmediateRegister(instr).code() * kOff12Mask; 840 delta += Assembler::GetCmpImmediateRegister(instr).code() * kOff12Mask;
841 // If the delta is 0 the instruction is cmp r0, #0 which also signals that 841 // If the delta is 0 the instruction is cmp r0, #0 which also signals that
842 // nothing was inlined. 842 // nothing was inlined.
843 if (delta == 0) { 843 if (delta == 0) {
844 return; 844 return;
845 } 845 }
846 846
847 if (FLAG_trace_ic) { 847 if (FLAG_trace_ic) {
848 PrintF("[ patching ic at %p, cmp=%p, delta=%d\n", address, 848 PrintF("[ patching ic at %p, cmp=%p, delta=%d\n",
849 cmp_instruction_address, delta); 849 static_cast<void*>(address),
850 static_cast<void*>(cmp_instruction_address), delta);
850 } 851 }
851 852
852 Address patch_address = 853 Address patch_address =
853 cmp_instruction_address - delta * Instruction::kInstrSize; 854 cmp_instruction_address - delta * Instruction::kInstrSize;
854 Instr instr_at_patch = Assembler::instr_at(patch_address); 855 Instr instr_at_patch = Assembler::instr_at(patch_address);
855 Instr branch_instr = 856 Instr branch_instr =
856 Assembler::instr_at(patch_address + Instruction::kInstrSize); 857 Assembler::instr_at(patch_address + Instruction::kInstrSize);
857 // This is patching a conditional "jump if not smi/jump if smi" site. 858 // This is patching a conditional "jump if not smi/jump if smi" site.
858 // Enabling by changing from 859 // Enabling by changing from
859 // cmp rx, rx 860 // cmp rx, rx
(...skipping 19 matching lines...) Expand all
879 patcher.EmitCondition(ne); 880 patcher.EmitCondition(ne);
880 } else { 881 } else {
881 DCHECK(Assembler::GetCondition(branch_instr) == ne); 882 DCHECK(Assembler::GetCondition(branch_instr) == ne);
882 patcher.EmitCondition(eq); 883 patcher.EmitCondition(eq);
883 } 884 }
884 } 885 }
885 } // namespace internal 886 } // namespace internal
886 } // namespace v8 887 } // namespace v8
887 888
888 #endif // V8_TARGET_ARCH_ARM 889 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ia32/disasm-ia32.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698