Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTrackElement.cpp

Issue 2001013003: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp b/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
index b8f3618b1572b8e5590aef533a92fbc6e65e9269..3b20683c4923926079c1d359f8e1e87957730a4a 100644
--- a/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
@@ -193,7 +193,7 @@ void HTMLTrackElement::loadTimerFired(Timer<HTMLTrackElement>*)
}
if (url == m_url) {
- ASSERT(m_loader);
+ DCHECK(m_loader);
switch (m_loader->loadState()) {
case TextTrackLoader::Idle:
case TextTrackLoader::Loading:
@@ -206,7 +206,7 @@ void HTMLTrackElement::loadTimerFired(Timer<HTMLTrackElement>*)
didCompleteLoad(Failure);
break;
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return;
}
@@ -271,8 +271,8 @@ void HTMLTrackElement::didCompleteLoad(LoadStatus status)
void HTMLTrackElement::newCuesAvailable(TextTrackLoader* loader)
{
- ASSERT_UNUSED(loader, m_loader == loader);
- ASSERT(m_track);
+ DCHECK_EQ(m_loader, loader);
+ DCHECK(m_track);
HeapVector<Member<TextTrackCue>> newCues;
m_loader->getNewCues(newCues);
@@ -282,8 +282,8 @@ void HTMLTrackElement::newCuesAvailable(TextTrackLoader* loader)
void HTMLTrackElement::newRegionsAvailable(TextTrackLoader* loader)
{
- ASSERT_UNUSED(loader, m_loader == loader);
- ASSERT(m_track);
+ DCHECK_EQ(m_loader, loader);
+ DCHECK(m_track);
HeapVector<Member<VTTRegion>> newRegions;
m_loader->getNewRegions(newRegions);
@@ -293,7 +293,7 @@ void HTMLTrackElement::newRegionsAvailable(TextTrackLoader* loader)
void HTMLTrackElement::cueLoadingCompleted(TextTrackLoader* loader, bool loadingFailed)
{
- ASSERT_UNUSED(loader, m_loader == loader);
+ DCHECK_EQ(m_loader, loader);
didCompleteLoad(loadingFailed ? Failure : Success);
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaSource.cpp ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698