Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2000993003:
[libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat. (Closed)
Description[libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat.
R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org,thakis@chromium.org
BUG=539572
Committed: https://crrev.com/be140444afefbe856622297c14327aaf186af91f
Cr-Commit-Position: refs/heads/master@{#395907}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add different encodings + small codestyle fixes. #
Total comments: 2
Patch Set 3 : Use isFinal as a variable + adding a comment. #
Messages
Total messages: 22 (8 generated)
This is a draft CL with an example of fuzzer for expat.
lgtm
https://codereview.chromium.org/2000993003/diff/1/third_party/expat/fuzz/expa... File third_party/expat/fuzz/expat_xml_parse_fuzzer.cc (right): https://codereview.chromium.org/2000993003/diff/1/third_party/expat/fuzz/expa... third_party/expat/fuzz/expat_xml_parse_fuzzer.cc:32: XML_Parser parser = XML_ParserCreate(NULL); Probably worth to use several possible values for the encoding parameter (not only NULL) as Kostya did in google3.
Not sure how soon we will remove expat (will we?), so probably worth to land this at least for some time. PTAL :)
lgtm https://codereview.chromium.org/2000993003/diff/20001/third_party/expat/fuzz/... File third_party/expat/fuzz/expat_xml_parse_fuzzer.cc (right): https://codereview.chromium.org/2000993003/diff/20001/third_party/expat/fuzz/... third_party/expat/fuzz/expat_xml_parse_fuzzer.cc:51: if (XML_Parse(parser, dataPtr, size, false) == XML_STATUS_ERROR) { move this false and true into a local isFinal and explain in a comment why we call XML_Parse with different isFinal values.
https://codereview.chromium.org/2000993003/diff/20001/third_party/expat/fuzz/... File third_party/expat/fuzz/expat_xml_parse_fuzzer.cc (right): https://codereview.chromium.org/2000993003/diff/20001/third_party/expat/fuzz/... third_party/expat/fuzz/expat_xml_parse_fuzzer.cc:51: if (XML_Parse(parser, dataPtr, size, false) == XML_STATUS_ERROR) { On 2016/05/25 14:16:19, inferno wrote: > move this false and true into a local isFinal and explain in a comment why we > call XML_Parse with different isFinal values. Done. Thanks!
The CQ bit was checked by inferno@chromium.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from kcc@chromium.org Link to the patchset: https://codereview.chromium.org/2000993003/#ps40001 (title: "Use isFinal as a variable + adding a comment.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000993003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== [libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat. R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org BUG=539572 ========== to ========== [libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat. R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org,thakis@chromium.org BUG=539572 ==========
mmoroz@chromium.org changed reviewers: + thakis@chromium.org
+thakis@, since //third_party/expat doesn't have an owner. Please take a look.
lgtm (sigh for having both libexpat and libxml)
The CQ bit was checked by mmoroz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000993003/40001
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat. R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org,thakis@chromium.org BUG=539572 ========== to ========== [libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat. R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org,thakis@chromium.org BUG=539572 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat. R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org,thakis@chromium.org BUG=539572 ========== to ========== [libfuzzer] Add expat_xml_parse_fuzzer for third_party/expat. R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org,thakis@chromium.org BUG=539572 Committed: https://crrev.com/be140444afefbe856622297c14327aaf186af91f Cr-Commit-Position: refs/heads/master@{#395907} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/be140444afefbe856622297c14327aaf186af91f Cr-Commit-Position: refs/heads/master@{#395907} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
