core/fpdfapi/fpdf_page/fpdf_page_doc.cpp - Issue 2000973002: Make CPDF_Function::Load() return an unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

Issue 2000973002: Make CPDF_Function::Load() return an unique_ptr. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: fix build, nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp b/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

index f0c5302b95a66ae0c28099e60d588b37ce474d45..ae02cfb4a769305dd29c4f0779fd1656c8ece148 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

@@ -351,8 +351,7 @@ CPDF_Pattern* CPDF_DocPageData::GetPattern(CPDF_Object* pPatternObj,

}

CPDF_Pattern* pPattern = nullptr;

if (bShading) {

- pPattern =

- new CPDF_ShadingPattern(m_pPDFDoc, pPatternObj, bShading, matrix);

+ pPattern = new CPDF_ShadingPattern(m_pPDFDoc, pPatternObj, TRUE, matrix);

} else {

CPDF_Dictionary* pDict = pPatternObj ? pPatternObj->GetDict() : nullptr;

if (pDict) {