Issue 20009: Fix memory leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20009: Fix memory leak. (Closed)

Created:
11 years, 10 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Patch Set 2 : Change to scoped_ptr. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/renderer/automation/dom_automation_controller.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kuchhal

I wasn't sure who should review this. This file doesn't seem to get modified a ...

11 years, 10 months ago (2009-02-03 01:54:56 UTC) #1

Erik does not do reviews

http://codereview.chromium.org/20009/diff/1/2 File chrome/renderer/automation/dom_automation_controller.cc (right): http://codereview.chromium.org/20009/diff/1/2#newcode70 Line 70: delete value; Instead, make value a scoped_ptr. It'll ...

11 years, 10 months ago (2009-02-03 16:03:30 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 20009: Fix memory leak. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Change to scoped_ptr. #

Messages