Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2000883003: Fixes Blimp engine browser test due to reading client token file. (Closed)

Created:
4 years, 7 months ago by haibinlu
Modified:
4 years, 7 months ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes Blimp engine browser test due to reading client token file. Uses const char[] for client assignment instead of reading it from the file. IO is not allowed on the thread. Because ScopedAllowIO is banned, posting task would make test setup flow harder to read. BUG=613595 Committed: https://crrev.com/cd769b0598af6e84b81b0bd1114aa2d362560040 Cr-Commit-Position: refs/heads/master@{#395234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M blimp/test/browser_tests/blimp_browser_test.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haibinlu
4 years, 7 months ago (2016-05-21 00:51:10 UTC) #2
Khushal
lgtm
4 years, 7 months ago (2016-05-21 01:27:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000883003/1
4 years, 7 months ago (2016-05-21 01:30:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-21 02:13:26 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 02:14:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd769b0598af6e84b81b0bd1114aa2d362560040
Cr-Commit-Position: refs/heads/master@{#395234}

Powered by Google App Engine
This is Rietveld 408576698