chrome/browser/ui/views/autofill/card_unmask_prompt_views_shim.cc - Issue 2000863002: MacViews: support Views credit card unmask prompt

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/autofill/card_unmask_prompt_views_shim.cc

Issue 2000863002: MacViews: support Views credit card unmask prompt (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build break with autofill namespace Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/views/autofill/card_unmask_prompt_views.h"

	6

	7 namespace autofill {

	8

	9 CardUnmaskPromptView* CreateCardUnmaskPromptView(

	10 CardUnmaskPromptController* controller,

	11 content::WebContents* web_contents) {

	12 return new CardUnmaskPromptViews(controller, web_contents);
	Evan Stade 2016/05/24 18:01:48 imo adding a whole new file for this, especially b imo adding a whole new file for this, especially because the gypi file needs to explicitly exclude it on mac, is not worth it. Why not just #if !defined(OS_MACOSX) in place? Elly Fong-Jones 2016/05/24 18:08:53 OS_MACOSX is true in mac_views_browser==1 builds, Show quoted text On 2016/05/24 18:01:48, Evan Stade wrote: > imo adding a whole new file for this, especially because the gypi file needs to > explicitly exclude it on mac, is not worth it. Why not just #if > !defined(OS_MACOSX) in place? OS_MACOSX is true in mac_views_browser==1 builds, which need to use the full Views stack and no Cocoa code. This file is included in mac_views_browser==1 builds but not Cocoa builds.
	13 }

	14

	15 }

OLD	NEW