Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2000853002: Fix BitrateAdjuster issues in VTVideoEncodeAccelerator (Closed)

Created:
4 years, 7 months ago by emircan
Modified:
4 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BitrateAdjuster issues in VTVideoEncodeAccelerator This CL addresses the bug below, where BitrateAdjuster would continue dropping the frame rate when bandwidth estimator kicks in. BUG=597095 Committed: https://crrev.com/2e5139a27bc056aecb53df143b85ee191f6a86e6 Cr-Commit-Position: refs/heads/master@{#395208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -25 lines) Patch
M media/gpu/vt_video_encode_accelerator_mac.h View 2 chunks +5 lines, -1 line 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 5 chunks +29 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
emircan
PTAL.
4 years, 7 months ago (2016-05-20 20:17:56 UTC) #3
sandersd (OOO until July 31)
media/ lgtm
4 years, 7 months ago (2016-05-20 20:40:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000853002/1
4 years, 7 months ago (2016-05-20 21:38:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 23:47:20 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 23:49:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e5139a27bc056aecb53df143b85ee191f6a86e6
Cr-Commit-Position: refs/heads/master@{#395208}

Powered by Google App Engine
This is Rietveld 408576698