Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: media/gpu/android_video_decode_accelerator.h

Issue 2000833003: Don't reset the codec state for a flush; this kills the frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Add dcheck. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/gpu/android_video_decode_accelerator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_GPU_ANDROID_VIDEO_DECODE_ACCELERATOR_H_ 5 #ifndef MEDIA_GPU_ANDROID_VIDEO_DECODE_ACCELERATOR_H_
6 #define MEDIA_GPU_ANDROID_VIDEO_DECODE_ACCELERATOR_H_ 6 #define MEDIA_GPU_ANDROID_VIDEO_DECODE_ACCELERATOR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 // from being sent after a reset. 427 // from being sent after a reset.
428 int error_sequence_token_; 428 int error_sequence_token_;
429 429
430 // PostError will defer sending an error if and only if this is true. 430 // PostError will defer sending an error if and only if this is true.
431 bool defer_errors_; 431 bool defer_errors_;
432 432
433 // True if and only if VDA initialization is deferred, and we have not yet 433 // True if and only if VDA initialization is deferred, and we have not yet
434 // called NotifyInitializationComplete. 434 // called NotifyInitializationComplete.
435 bool deferred_initialization_pending_; 435 bool deferred_initialization_pending_;
436 436
437 // Indicates if ResetCodecState() should be called upon the next call to
438 // Decode(). Allows us to avoid trashing the last few frames of a playback
439 // when the EOS buffer is received.
440 bool codec_needs_reset_;
441
437 // Copy of the VDA::Config we were given. 442 // Copy of the VDA::Config we were given.
438 Config config_; 443 Config config_;
439 444
440 OnDestroyingSurfaceCallback on_destroying_surface_cb_; 445 OnDestroyingSurfaceCallback on_destroying_surface_cb_;
441 446
442 // WeakPtrFactory for posting tasks back to |this|. 447 // WeakPtrFactory for posting tasks back to |this|.
443 base::WeakPtrFactory<AndroidVideoDecodeAccelerator> weak_this_factory_; 448 base::WeakPtrFactory<AndroidVideoDecodeAccelerator> weak_this_factory_;
444 449
445 friend class AndroidVideoDecodeAcceleratorTest; 450 friend class AndroidVideoDecodeAcceleratorTest;
446 }; 451 };
447 452
448 } // namespace media 453 } // namespace media
449 454
450 #endif // MEDIA_GPU_ANDROID_VIDEO_DECODE_ACCELERATOR_H_ 455 #endif // MEDIA_GPU_ANDROID_VIDEO_DECODE_ACCELERATOR_H_
OLDNEW
« no previous file with comments | « no previous file | media/gpu/android_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698