[TabManager] Unit tests to make sure of the number of times tabs can be discarded.

[TabManager] Unit tests to make sure of the number of times tabs can be discarded.

BUG=612435, 612256
Committed: https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0
Cr-Commit-Position: refs/heads/master@{#395960}

[Anderson Silva, 2016-05-20 20:01:14]

Description was changed from

==========
[TabManager] Unit tests to make sure of the number of times tabs can be
discarded.

[TabManager] Unit tests for multiple discards flag.

BUG=612435,612256
==========

to

==========
[TabManager] Unit tests to make sure of the number of times tabs can be
discarded.

BUG=612435,612256
==========

[Anderson Silva, 2016-05-20 20:01:14]

andersoncss@google.com changed reviewers:
+ georgesak@chromium.org

[Anderson Silva, 2016-05-20 20:02:09]

PTAL

[Anderson Silva, 2016-05-25 17:07:32]

PTAL

[Georges Khalil, 2016-05-25 17:15:09]

Nice. LGTM % nits.

https://codereview.chromium.org/2000833002/diff/60001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_unittest.cc (right):

https://codereview.chromium.org/2000833002/diff/60001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:442: // Tests related to platforms
that fully supports TabManager.
nit: Reword this comment and put it above the #ifdef.

Test to see if a tab can only be discarded once. On Windows and Mac, this
defaults to true unless overridden through a variation parameter. On other
platforms, it's always false.

https://codereview.chromium.org/2000833002/diff/60001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:487: // Tests for platforms that
doesn't fully support TabManager.
nit: remove this comment as the above one will take care of it.

https://codereview.chromium.org/2000833002/diff/60001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:495: 
nit: add "  // defined(OS_WIN) || defined(OS_MACOSX)" (2 spaces between #endif
and //).

[Anderson Silva, 2016-05-25 17:36:53]

The CQ bit was checked by andersoncss@google.com

[Anderson Silva, 2016-05-25 17:36:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
georgesak@chromium.org
Link to the patchset: https://codereview.chromium.org/2000833002/#ps80001
(title: "Fixing nits")

[commit-bot: I haz the power, 2016-05-25 17:37:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000833002/80001

[Georges Khalil, 2016-05-25 17:38:25]

https://codereview.chromium.org/2000833002/diff/80001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_unittest.cc (right):

https://codereview.chromium.org/2000833002/diff/80001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:493: #endif  // #if
defined(OS_WIN) || defined(OS_MACOSX)
No "#if" here. We can fix this in the next CL.

[Anderson Silva, 2016-05-25 17:39:47]

The CQ bit was unchecked by andersoncss@google.com

[Anderson Silva, 2016-05-25 17:44:12]

The CQ bit was checked by andersoncss@google.com

[Anderson Silva, 2016-05-25 17:44:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
georgesak@chromium.org
Link to the patchset: https://codereview.chromium.org/2000833002/#ps100001
(title: "Fixing final NIT")

[commit-bot: I haz the power, 2016-05-25 17:44:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000833002/100001

[commit-bot: I haz the power, 2016-05-25 19:26:40]

Description was changed from

==========
[TabManager] Unit tests to make sure of the number of times tabs can be
discarded.

BUG=612435,612256
==========

to

==========
[TabManager] Unit tests to make sure of the number of times tabs can be
discarded.

BUG=612435,612256
==========

[commit-bot: I haz the power, 2016-05-25 19:26:41]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-25 19:27:55]

Description was changed from

==========
[TabManager] Unit tests to make sure of the number of times tabs can be
discarded.

BUG=612435,612256
==========

to

==========
[TabManager] Unit tests to make sure of the number of times tabs can be
discarded.

BUG=612435,612256

Committed: https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0
Cr-Commit-Position: refs/heads/master@{#395960}
==========

[commit-bot: I haz the power, 2016-05-25 19:27:56]

Patchset 6 (id:??) landed as
https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0
Cr-Commit-Position: refs/heads/master@{#395960}