Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Issue 2000833002: [TabManager] Unit tests to make sure of the number of times tabs can be discarded. (Closed)

Created:
4 years, 7 months ago by Anderson Silva
Modified:
4 years, 5 months ago
Reviewers:
Georges Khalil
CC:
chromium-reviews, chrisha
Base URL:
https://chromium.googlesource.com/chromium/src.git@bug605533
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TabManager] Unit tests to make sure of the number of times tabs can be discarded. BUG=612435, 612256 Committed: https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0 Cr-Commit-Position: refs/heads/master@{#395960}

Patch Set 1 #

Patch Set 2 : [TabManager] Unit tests for CanOnlyDiscardOnce method. #

Patch Set 3 : [TabManager] CanDiscardOnlyOnce unit tests. #

Patch Set 4 : [TabManager #

Total comments: 3

Patch Set 5 : Fixing nits #

Total comments: 1

Patch Set 6 : Fixing final NIT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M chrome/browser/memory/tab_manager.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory/tab_manager_unittest.cc View 1 2 3 4 5 3 chunks +59 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
Anderson Silva
PTAL
4 years, 7 months ago (2016-05-20 20:02:09 UTC) #3
Anderson Silva
PTAL
4 years, 6 months ago (2016-05-25 17:07:32 UTC) #4
Georges Khalil
Nice. LGTM % nits. https://codereview.chromium.org/2000833002/diff/60001/chrome/browser/memory/tab_manager_unittest.cc File chrome/browser/memory/tab_manager_unittest.cc (right): https://codereview.chromium.org/2000833002/diff/60001/chrome/browser/memory/tab_manager_unittest.cc#newcode442 chrome/browser/memory/tab_manager_unittest.cc:442: // Tests related to platforms ...
4 years, 6 months ago (2016-05-25 17:15:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000833002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000833002/80001
4 years, 6 months ago (2016-05-25 17:37:28 UTC) #8
Georges Khalil
https://codereview.chromium.org/2000833002/diff/80001/chrome/browser/memory/tab_manager_unittest.cc File chrome/browser/memory/tab_manager_unittest.cc (right): https://codereview.chromium.org/2000833002/diff/80001/chrome/browser/memory/tab_manager_unittest.cc#newcode493 chrome/browser/memory/tab_manager_unittest.cc:493: #endif // #if defined(OS_WIN) || defined(OS_MACOSX) No "#if" here. ...
4 years, 6 months ago (2016-05-25 17:38:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000833002/100001
4 years, 6 months ago (2016-05-25 17:44:36 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-05-25 19:26:41 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 19:27:56 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e932f6660251e72cbf3b712be6ac28a9e00c11f0
Cr-Commit-Position: refs/heads/master@{#395960}

Powered by Google App Engine
This is Rietveld 408576698