chrome/browser/interests/interests_fetcher.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/interests/interests_fetcher.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/content_settings/content_settings_store.cc ('K') | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | chrome/browser/ui/webui/options/certificate_manager_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/interests/interests_fetcher.cc

diff --git a/chrome/browser/interests/interests_fetcher.cc b/chrome/browser/interests/interests_fetcher.cc

index 49ba04da0682daa3d12d61e2232c6dc750192d95..0b755d11b07842fb46ba8e567b25556e81ddd509 100644

--- a/chrome/browser/interests/interests_fetcher.cc

+++ b/chrome/browser/interests/interests_fetcher.cc

@@ -182,7 +182,7 @@ InterestsFetcher::ExtractInterests(const std::string& response) {

}

std::unique_ptr<std::vector<Interest>> res(new std::vector<Interest>());

- for (const base::Value* entry : *interests_list) {

+ for (const auto& entry : *interests_list) {

const base::DictionaryValue* interest_dict = nullptr;

if (!entry->GetAsDictionary(&interest_dict)) {

DLOG(WARNING) << "Failed to parse interest dictionary.";