Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: chrome/browser/extensions/api/gcd_private/gcd_private_api.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/gcd_private/gcd_private_api.cc
diff --git a/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc b/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc
index 2d3a5df9d54d9cd445ca4055463db2ba8f4b7bea..9541d0efa5c7a929297dc2b82d40a8cfadddddc6 100644
--- a/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc
+++ b/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc
@@ -312,7 +312,7 @@ void GcdPrivateCreateSessionFunction::OnSessionInitialized(
if (status == gcd_private::STATUS_SUCCESS) {
const base::ListValue* pairing = nullptr;
if (info.GetList("authentication.pairing", &pairing)) {
- for (const base::Value* value : *pairing) {
+ for (const auto& value : *pairing) {
std::string pairing_string;
if (value->GetAsString(&pairing_string)) {
api::gcd_private::PairingType pairing_type =

Powered by Google App Engine
This is Rietveld 408576698