Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/json_schema_compiler/util.h

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: meh Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/util.h
diff --git a/tools/json_schema_compiler/util.h b/tools/json_schema_compiler/util.h
index 220ba80c77df5e3af43d5d2cca7fa347487d291a..8b852739f6a1078b5fca50e38612fdd49e4bf6b1 100644
--- a/tools/json_schema_compiler/util.h
+++ b/tools/json_schema_compiler/util.h
@@ -101,7 +101,7 @@ template <class T>
bool PopulateArrayFromList(const base::ListValue& list, std::vector<T>* out) {
out->clear();
T item;
- for (const base::Value* value : list) {
+ for (const auto& value : list) {
if (!PopulateItem(*value, &item))
return false;
// T might not be movable, but in that case it should be copyable, and this
@@ -120,7 +120,7 @@ bool PopulateArrayFromList(const base::ListValue& list,
base::string16* error) {
out->clear();
T item;
- for (const base::Value* value : list) {
+ for (const auto& value : list) {
if (!PopulateItem(*value, &item, error))
return false;
out->push_back(std::move(item));

Powered by Google App Engine
This is Rietveld 408576698