extensions/common/extension_api.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_api.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: meh Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc ('K') | « extensions/browser/verified_contents.cc ('k') | extensions/common/features/base_feature_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extension_api.cc

diff --git a/extensions/common/extension_api.cc b/extensions/common/extension_api.cc

index 1fee5b3c8b272719f2db9108d0288ec63655c8fc..8430a2fb117dead341b92dc8d8790f75196aeffc 100644

--- a/extensions/common/extension_api.cc

+++ b/extensions/common/extension_api.cc

@@ -132,8 +132,8 @@ void PrefixRefsWithNamespace(const std::string& schema_namespace,

base::ListValue* list = NULL;

base::DictionaryValue* dict = NULL;

if (value->GetAsList(&list)) {

- for (base::ListValue::iterator i = list->begin(); i != list->end(); ++i) {

- PrefixRefsWithNamespace(schema_namespace, *i);

+ for (const auto& i : *list) {

+ PrefixRefsWithNamespace(schema_namespace, i.get());

}

} else if (value->GetAsDictionary(&dict)) {

MaybePrefixFieldWithNamespace(schema_namespace, dict, "$ref");