Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: meh Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc
index 2bc53aa8e0d80744cf12ad315954155a8fdd35ec..d4b7772230c3b311794e60c6fa760cf6a4ff587d 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc
@@ -478,7 +478,7 @@ void WebUILoginView::RequestMediaAccessPermission(
const base::ListValue* list_value;
CHECK(raw_list_value->GetAsList(&list_value));
- for (base::Value* base_value : *list_value) {
+ for (const auto& base_value : *list_value) {
std::string value;
if (base_value->GetAsString(&value)) {
ContentSettingsPattern pattern =

Powered by Google App Engine
This is Rietveld 408576698