services/catalog/instance.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/catalog/instance.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/catalog/instance.cc

diff --git a/services/catalog/instance.cc b/services/catalog/instance.cc

index 6673f35ab5eabd4928bde13bfad7cd187e1d2c2a..d90126646259f11c4fb207fd036f75430da0ba4a 100644

--- a/services/catalog/instance.cc

+++ b/services/catalog/instance.cc

@@ -145,9 +145,8 @@ void Instance::DeserializeCatalog() {

CHECK(catalog);

// TODO(sky): make this handle aliases.

// TODO(beng): implement this properly!

- for (auto it = catalog->begin(); it != catalog->end(); ++it) {

+ for (const auto& v : *catalog) {

const base::DictionaryValue* dictionary = nullptr;

- const base::Value* v = *it;

CHECK(v->GetAsDictionary(&dictionary));

std::unique_ptr<Entry> entry = Entry::Deserialize(*dictionary);

// TODO(beng): user catalog.

« no previous file with comments | « services/catalog/entry.cc ('k') | sync/test/fake_server/fake_server_verifier.cc » ('j') | no next file with comments »