net/http/http_server_properties_manager.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties_manager.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_server_properties_manager.cc

diff --git a/net/http/http_server_properties_manager.cc b/net/http/http_server_properties_manager.cc

index 67dd80e8c6c74c3a2386a7d10adae734fcdd227e..35fcea868776e453106e4ec7c5ae0eb37665a6fe 100644

--- a/net/http/http_server_properties_manager.cc

+++ b/net/http/http_server_properties_manager.cc

@@ -716,8 +716,7 @@ bool HttpServerPropertiesManager::AddToAlternativeServiceMap(

}

AlternativeServiceInfoVector alternative_service_info_vector;

- for (const base::Value* alternative_service_list_item :

- *alternative_service_list) {

+ for (const auto& alternative_service_list_item : *alternative_service_list) {

const base::DictionaryValue* alternative_service_dict;

if (!alternative_service_list_item->GetAsDictionary(

&alternative_service_dict))

« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | remoting/protocol/http_ice_config_request.cc » ('j') | no next file with comments »