extensions/browser/api/system_network/system_network_apitest.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_network/system_network_apitest.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_private/networking_private_chromeos.cc ('k') | extensions/browser/verified_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/system_network/system_network_apitest.cc

diff --git a/extensions/browser/api/system_network/system_network_apitest.cc b/extensions/browser/api/system_network/system_network_apitest.cc

index 047857e2120fcdd4aa0a39ca8e53813e73b9a741..b49657552551c130e772ef824c45a9defa6bf0ac 100644

--- a/extensions/browser/api/system_network/system_network_apitest.cc

+++ b/extensions/browser/api/system_network/system_network_apitest.cc

@@ -43,10 +43,7 @@ IN_PROC_BROWSER_TEST_F(SystemNetworkApiTest, GetNetworkInterfaces) {

base::ListValue* value = static_cast<base::ListValue*>(result.get());

ASSERT_TRUE(value->GetSize() > 0);

- for (base::ListValue::const_iterator it = value->begin(); it != value->end();

- ++it) {

- base::Value* network_interface_value = *it;

+ for (const auto& network_interface_value : *value) {

NetworkInterface network_interface;

ASSERT_TRUE(NetworkInterface::Populate(*network_interface_value,

&network_interface));